From: Junio C Hamano Date: Tue, 27 Mar 2012 20:18:56 GMT Subject: Re: [PATCH v4 0/3] Isolate If-Modified-Since handling in gitweb Message-ID: <7vzkb1hk5r.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120327195558.GA32699@odin.tremily.us> "W. Trevor King" writes: > On Tue, Mar 27, 2012 at 08:24:22PM +0100, Jakub Narebski wrote: >> No, the status line was omitted unintentionally, thanks for fixing this. >> I guess that web server (at least Apache) adds it if it is missing. > > From the CGI 1.1 specs [1], section 9.2: > > If the script does not return a Status header, then "200 OK" should > be assumed. > > So, perhaps it is better to skip the Status header on success (less > for the server to parse). I do not think it matters either way. It is just a single header line, no? The code is certainly more explicit with your patch.