From: Junio C Hamano Date: Wed, 09 May 2012 18:08:00 GMT Subject: Re: [PATCH 02/19] tests: add tests for the bash prompt functions in the completion script Message-ID: <7vzk9hrzwf.fsf@alter.siamese.dyndns.org> In-Reply-To: <4FAA25A7.4020300@viscovery.net> Johannes Sixt writes: > From: Johannes Sixt > Subject: [PATCH] fixup! tests: add tests for the bash prompt functions in the > completion script > > - $TRASH_DIRECTORY is /c/dir style path, but git produces c:/dir style > paths. Use $(pwd), which is short for $(pwd -W) that produces the > latter, to assemble expected test data and paths read by git. This comes up very often whenever somebody (including me) touches test scripts. We do have a write-up in t/README in "Dos and Don'ts" section, but apparently that is not sufficient to avoid fix-ups. Would it be possible to arrange so that $TRASH_DIRECTORY, $TEST_DIRECTORY and $PWD are set to c:/dir style paths in Windows environment? What would we break if we did so? The other direction of changing the Windows port of git to produce /c/dir style paths would probably not work, as it would involve ripping out the path mangling feature of bash in MSYS, which is done for some reason, I presume.