From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 30 Aug 2012 05:26:18 GMT
Subject: Re: [PATCH v2] test: set the realpath of CWD as TRASH_DIRECTORY
Message-ID: <7vzk5dt0g5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <503EEDF3.2080202@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> By the way, is the use of realpath(3) permissible in git code?
> GIT_CEILING_DIRECTORIES handling could be fixed relatively easily by
> using this function to canonicalize pathnames before comparison.

As long as we can add a compat/realpath.c (perhaps lift one from
glibc before they went GPLv3) for platforms that matter, I do not
see it as a huge problem.  How close is abspath.c::real_path() to
what you need?

> [1] This would be analogous to the inclusion of a space in "trash
> directory.*", which I presume was done to detect space-handling problems
> quickly.

Yeah, understood where you are coming from, and I think I can agree
with where you are trying to go.