From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Sep 2012 23:26:08 GMT
Subject: Re: [PATCHv7] clone --single: limit the fetch refspec to fetched branch
Message-ID: <7vzk4legrz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1348073136-8842-1-git-send-email-ralf.thielow@gmail.com>

Ralf Thielow <ralf.thielow@gmail.com> writes:

> diff --git a/t/t5709-clone-refspec.sh b/t/t5709-clone-refspec.sh
> new file mode 100755
> index 0000000..69a0779
> --- /dev/null
> +++ b/t/t5709-clone-refspec.sh
> @@ -0,0 +1,155 @@
> +#!/bin/sh
> +
> +test_description='test refspec written by clone-command'
> +. ./test-lib.sh
> +
> +test_expect_success 'setup' '
> +	# Make two branches, "master" and "side"
> + ...
> +	# explicit --single with tag
> +	git clone --single-branch --branch two . dir_tag &&
> +
> +	# advance both "master" and "side" branches
> +	git checkout side &&
> +	echo five >file &&
> +	git commit -a -m five &&
> +	git checkout master &&
> +	echo six >file &&
> +	git commit -a -m six
> +'
> +
> + ...
> +test_expect_success '--single-branch with explicit --branch with tag fetches updated tag' '
> +	git tag -d two && git tag two &&

Curious.  Was it insufficient to update this tag at the end of the
"setup" process like everybody else where

	# advance both "master" and "side" branches

happens?

Not that it is wrong to do this, but it looked somewhat
inconsistent.