From: Junio C Hamano Date: Mon, 13 May 2013 13:53:29 GMT Subject: Re: [PATCH] patch-ids.c: cache patch IDs in a notes tree Message-ID: <7vzjvzoujq.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130513075906.GP2299@serenity.lan> John Keeping writes: > The caching layer could also introduce false positives though, which is > more serious. If you cache patch IDs with a pathspec restriction ... What? What business does patch-id have with pathspec-limited diff generation? You do not rebase or cherry-pick with pathspec, so unless you are populating the patch-id cache at a wrong point (like, say whenevern "git show $commit" is run), I am not sure why pathspec limit becomes even an issue.