From: Junio C Hamano <junkio@cox.net>
Date: Wed, 21 Jun 2006 20:53:32 GMT
Subject: Re: [PATCH] Check and document the options to prevent mistakes.
Message-ID: <7vy7vqxmb7.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <m164iu8x78.fsf@ebiederm.dsl.xmission.com>

ebiederm@xmission.com (Eric W. Biederman) writes:

> +# Verify the user input
> +
> +foreach my $entry (@to) {
> +	die "Comma in --to entry: $entry'\n" unless $entry !~ m/,/;
> +}
> +

Perhaps, avoiding double negation would be easier on the eyes.

        die ... if $entry =~ /,/

Does it grok '"Biederman, Eric W." <eb@xm.com>' some people seem
to do properly, or do we care (I personally don't)?