From: Junio C Hamano Date: Sat, 08 Jul 2006 18:51:26 GMT Subject: Re: [PATCH] Remove more gcc extension usage. Message-ID: <7vy7v4orpt.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20060708183402.GA17644@spearce.org> Shawn Pearce writes: > Removing these last remaining extension uses allows GIT to compile > with the Sun C compiler rather then gcc. This can be handy when > you are trying to compile GIT on a Solaris system that seems to > have a total lack of GNU utilities. Two points. - Aren't the constructs you ripped out not GCC extension, rather proper ISO C99? - Our Makefile is pretty GNU already. I think people have pointed out and ripped out bashisms from our shell scripts, but I would not be surprised if the default Sun /bin/sh does not understand POSIXy features some of them use.