From: Junio C Hamano <junkio@cox.net>
Date: Fri, 18 May 2007 21:01:01 GMT
Subject: Re: [PATCH] gitweb: Extra columns in blame
Message-ID: <7vy7jl4zjm.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070518191725.10460.83338.stgit@rover>

Good job, except that I think you should also show the filename
especially as you seem to run with -C (I haven't looked at the
code yet, though).

E.g.

http://repo.or.cz/w/linux-2.6.git?a=blame_incremental;f=block/ll_rw_blk.c;h=6b5173ac81313d8adb5c1d7b521559f565bb209b;hb=347b4599dd6ffef27e18c227532d1ec66556000b

the first few hunks that came from 1da177e4 are from a different
file, drivers/block/ll_rw_blk.c.

Also the incremental thing using JavaScript does not seem to
work for me incrementally for some reason, although if I wait
long enough I get the fully blamed picture that seems to match
nonincremental one.  While I am waiting, the browser goes silent
and does not even let me switch to other tabs, so it is not all
that useful to me in its current shape.