From: Junio C Hamano Date: Sat, 02 Jun 2007 19:58:22 GMT Subject: Re: [PATCH] Make the installation targets a little less chatty Message-ID: <7vy7j2p1r5.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20070601230924.GA6360@steel.home> Alex Riesen writes: > by default. V=1 works as usual. You obviously did not test that X-<. V=1 does not work at all for me. This is what I get. ... install git '/home/junio/git-test/bin' :SETUP BUILTIN git-format-patch; rm -f '/home/junio/git-test/bin/git-format-patch' && ln '/home/junio/git-test/bin/git' '/home/junio/git-test/bin/git-format-patch'; ... ... /bin/sh: :SETUP: command not found /bin/sh: :SETUP: command not found /bin/sh: :SETUP: command not found /bin/sh: :SETUP: command not found ... Two problems and a half. (0) You do not report the creation of target directory done with "install -d", so without $V there is no way to tell if things are installed in the expected location. (1) Obviously : and whatever action message needs to be separated so that it becomes a no-op command ':' followed by parameters; (2) Even with that ":SETUP: command not found" fixed, it now makes the command line twice as long as before for $V case, which makes it harder to diagnose a problem when Makefile goes wrong. I think the way QUIET_CC and friends are done is quite sensible and does not have this problem, especially (3). With V=1 it just becomes transparent, and that is what we would want.