From: Junio C Hamano Date: Sat, 07 Jul 2007 02:13:46 GMT Subject: Re: [RFC/PATCH] interpolate '\n' as newline Message-ID: <7vy7htc65h.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > All places which call interpolate() get this interpolation for free. > > Signed-off-by: Johannes Schindelin > > --- > > In the back of my head, I remembered that a few people > were interested in this. > > Judging by the diffstat, it really escapes me why these people > did not implement it. > > However, there is a chance that this change is not liked by > all places that call interpolate(). merge-recursive can live > with it, I guess. I actually think merge-recursive has much bigger chance of getting broken than git-daemon, but only _if_ people are already using custom merge programs this becomes an issue. It is much more common to see two letter sequence '\n' as a string literal in a script than in a pathname. > But daemon interpolates the path... However, > it seems only the command line of daemon can change the string, > so this change should be safe. The command line needs to say --interpolated-path="...\n..." and expect that '\n' would come out as two characters backslash and en in the _pathname_ to get broken, and it is very unlikely that anybody is insane enough to have such a path.