From: Junio C Hamano Date: Thu, 30 Aug 2007 21:55:39 GMT Subject: Re: [PATCH] git-filter-branch: document --original option Message-ID: <7vy7fs7kmc.fsf@gitster.siamese.dyndns.org> In-Reply-To: <11884938431525-git-send-email-giuseppe.bilotta@gmail.com> Giuseppe Bilotta writes: > +--original :: > + Use this option to set the namespace where the original commits > + will be stored. The default value is 'refs/original'. > + The default seems to be "refs/original/". Even worse. I think if you say --force --original refs/head (notice the lack of "s" nor slash at the end), the code will get you in a *lot* of trouble. Dscho, don't we want to do something like this? --- git-filter-branch.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/git-filter-branch.sh b/git-filter-branch.sh index 0190060..a7f50a6 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -134,6 +134,7 @@ do filter_subdir="$OPTARG" ;; --original) + case "$OPTARG" in */) ;; *) OPTARG="$OPTARG/" ;; esac orig_namespace="$OPTARG" ;; *)