From: Junio C Hamano Date: Sun, 09 Dec 2007 18:36:53 GMT Subject: Re: [PATCH 2/4] Use strbuf in http code Message-ID: <7vy7c3ogu2.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071209182408.GA9427@glandium.org> Mike Hommey writes: > Both codes are also buggy in case the ref is a symbolic ref, and that > happens. I got bitten by this while testing. > > Considering the assumption being made that refs are all properly filled > with sha1s, both codes are mostly equally bad. > > Fixing the issue would obviously be the subject for another patch. Ok, I'll reject [2/4] and expect a reroll.