From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 16 Jan 2008 22:55:41 GMT
Subject: Re: [PATCH 2/2] close_lock_file(): new function in the lockfile API
Message-ID: <7vy7apmlci.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <478E893F.4070100@nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

> Mainly, I prefer to not modify the data structures when a failure occurs.

Ok.  Is the rest of your patch that fixes callers Ok with that
semantics?  If so, I'd agree that is probably cleaner.  I'll
scrap the one we are discussing, resurrecting only the api
documentation part, and replace it with the lockfile.c changes
from your patch, along with the fixes to callers.