From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 01 Apr 2008 05:39:35 GMT
Subject: Re: [PATCH] mktag.c: tweak validation of tagger field and adjust test script
Message-ID: <7vy77ygmlk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <47F172E3.7010104@nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

>  	/*
>  	 * Check for correct form for name and email
>  	 * i.e. " <" followed by "> " on _this_ line
> +	 * No angle brackets within the name or email address fields.
> +	 * No spaces within the email address field.
>  	 */
>  	tagger_line += 7;
>  	if (!(lb = strstr(tagger_line, " <")) || !(rb = strstr(lb+2, "> ")) ||
> +		strpbrk(tagger_line, "<>\n") != lb+1 ||
> +		strpbrk(lb+2, "><\n ") != rb)
> +		return error("char" PD_FMT ": malformed tagger field",
>  			tagger_line - buffer);

This is the first use of strpbrk() in git.git codebase.  Are BSD folks Ok
with it (I understand this came from SVID 1, just like strspn we already
use elsewhere)?