From: Junio C Hamano Date: Tue, 22 Apr 2008 16:56:29 GMT Subject: Re: [PATCH v2 04/13] Teach rebase interactive the mark command Message-ID: <7vy775ygjm.fsf@gitster.siamese.dyndns.org> In-Reply-To: Johannes Schindelin writes: > So I really hate the idea of introducing yet other marks when we already > have unique identifiers: the (abbreviated) commit names. Didn't I give you an example why commit object names are _not_ unique identifiers already? I also do not understand why you think 'mark' is ugly. I _suspect_ that the machinery to read the TODO insns would need to keep a copy of what it gave to the end user, compare it with what user edited to make sure the user did not make nonsense insn sequence out of it, which Jörg's code doesn't do (yet), and I suspect a simple rule like "you cannot move insns across 'mark' boundary" would be sufficient for that check.