From: Junio C Hamano Date: Thu, 15 May 2008 01:52:55 GMT Subject: Re: [PATCH 2/2] Provide git_config with a callback-data parameter Message-ID: <7vy76cib9k.fsf@gitster.siamese.dyndns.org> In-Reply-To: Johannes Schindelin writes: >> Great, as this has also been a pet-peeve of mine for quite some time. >> >> Except the patch has quite a many rejects X-<. > > Did you try to apply it to "next"? The rejects are Ok. As long as function signature change of git_config() is there, any misconversion will be caught by the compiler so I can manage with relatively high confidence. I need manual inspection on the other patch, as s/path.list/string.list/ could oversubstitute without breaking compilation.