From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Feb 2009 02:24:51 GMT
Subject: Re: [PATCH v2 4/8] config: Disallow multiple variable types.
Message-ID: <7vy6w5ajgs.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1234832094-15541-4-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> +	if (HAS_MULTI_BITS(types)) {
> +		error("only one type at a time.");
> +		usage_with_options(builtin_config_usage, builtin_config_options);
> +	}

You would be able to catch "config --bool --get-color color.diff.whitespace"
as an error by doing something similar to the "fake actions" for get-color*
as I suggested in my review on [3/8].

I did not find anything objectionable in the remainder of the series.

Thanks.