From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 28 Feb 2009 17:29:58 GMT
Subject: Re: [PATCH] fix git format-patch --cc=<email> format
Message-ID: <7vy6vqfp0p.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <76718490902280815if1c3fa7o790112b410d52224@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> On Sat, Feb 28, 2009 at 7:42 AM, Peng Tao <bergwolf@gmail.com> wrote:
>> If there are multiple --cc=<email> arguments, git format-patch will generate
>> patches with cc lines like:
>>  Cc: <email>,
>>      <email>
>> which git send-email fails to parse.
>> git send-email only accept formats like:
>>  Cc: <email>
>>  Cc: <email>
>> So change git format-patch to generate patches in a proper format.
>
> This is fixed in next, but we fixed send-email instead to handle the
> messages that format-patch generates, as they should be valid.

Per RFC2822 3.6 (pp 19-20), "cc" is to appear at most once (same is true
for "to" and "bcc").  I think fix to format-patch is necessary regardless
of what send-email does.