From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Jul 2009 20:16:45 GMT
Subject: Re: [PATCH] request-pull: do not paginate output of git commands
Message-ID: <7vy6r8f9aq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090701094029.GA22508@sepie.suse.cz>

Michal Marek <mmarek@suse.cz> writes:

> Good idea, but for completeness, it should be set before this command:
>     git log --max-count=1 --pretty='format:warn:   %h: %s' $headrev >&2
> (which should use tformat to get the newline right). So what about this
> one?

Good eyes.

The blamed commit for that new use of "log" is ff06c74 (Improve
request-pull to handle non-rebased branches, 2007-05-01) itself, which did
introduce the "define an empty PAGER to disable paging" trick, so this
makes it doubly buggy (i.e. for forgetting GIT_PAGER trumps PAGER, and for
introducing a use of log that is not covered by its own trick).

Thanks.