From: Junio C Hamano Date: Thu, 27 Aug 2009 21:50:11 GMT Subject: Re: [PATCHv4 08/12] Teach the notes lookup code to parse notes trees with various fanout schemes Message-ID: <7vy6p5ncz0.fsf@alter.siamese.dyndns.org> In-Reply-To: <20090827212710.GV1033@spearce.org> "Shawn O. Pearce" writes: > Yea, it was me. I still think it might be a useful idea, since > it allows you better density of loading notes when parsing the > recent commits. In theory the last 256 commits can easly be in > each of the 2/ fanout buckets, making 2/38 pointless for reducing > the search space. Commit date on the other hand can probably force > all of them into the same bucket, making it easy to have the last > 256 commits in cache, from a single bucket. > > But I thought you shot it down, by saying that we also wanted to > support notes on blobs. I happen to see no value in a note on > a blob, a blob alone doesn't make much sense without at least an > annotated tag or commit to provide it some named context, and the > latter two have dates. Yeah, and in this thread everybody seems to be talking about commits so I think it is fine to limit notes only to commits.