From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 29 Dec 2009 09:19:51 GMT
Subject: Re: [PATCH] Smart-http: check if repository is OK to export before serving it
Message-ID: <7vy6kmjfwo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1262036940-9678-1-git-send-email-tarmigan+git@gmail.com>

Tarmigan Casebolt <tarmigan+git@gmail.com> writes:

> Similar to how git-daemon checks whether a repository is OK to be
> exported, smart-http should also check.  This check can be satisfied
> in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
> may be set to export all repositories, or the individual repository
> may have the file git-daemon-export-ok.
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
> Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
> ---
> OK, I see what you're saying Shawn.  I've changed it back to "404 
> Not Found" again.
>
> I've also reordered the new tests since the last time I sent it out.
> The new tests use the same test as in
> "static file is ok"
> so put the new tests after that test in case that test breaks.

Looks sane to me, although I am afraid that I am not as familiar with the
codepath involved as I should be.  Shawn, is your Ack still good?