From: Junio C Hamano Date: Sat, 20 Feb 2010 20:01:05 GMT Subject: Re: [PATCH 4/4] Use git_mkstemp_mode and xmkstemp_mode in odb_mkstemp, not chmod later. Message-ID: <7vy6inekxq.fsf@alter.siamese.dyndns.org> In-Reply-To: <1266597207-32036-5-git-send-email-Matthieu.Moy@imag.fr> Matthieu Moy writes: > diff --git a/t/t1304-default-acl.sh b/t/t1304-default-acl.sh > index 4ee44a1..b8e9c34 100755 > --- a/t/t1304-default-acl.sh > +++ b/t/t1304-default-acl.sh > @@ -27,7 +27,7 @@ modebits () { > ls -l "$1" | sed -e 's|^\(..........\).*|\1|' > } > > -test_expect_failure 'git gc does not break ACLs with restrictive umask' ' > +test_expect_success 'git gc does not break ACLs with restrictive umask' ' > umask 077 && > git gc && > actual=$(modebits .git/objects/pack/*.pack) && This does not seem to pass for me; I get 0444 instead of 0440 as you expect.