From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 Sep 2010 23:31:45 GMT
Subject: Re: [PATCH] tests: use test_cmp instead of piping to diff(1)
Message-ID: <7vy6b59q5a.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1284411582-1088-1-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> @@ -37,9 +37,10 @@ head1=$(add_file sm1 foo1 foo2)
>  test_expect_success 'added submodule' "
>  	git add sm1 &&
>  	git diff-index -p --submodule=log HEAD >actual &&
> -	diff actual - <<-EOF
> +	cat >expected <<-EOF &&
>  Submodule sm1 0000000...$head1 (new submodule)
>  EOF
> +    test_cmp expected actual
>  "

Nit.  Did you really mean <<-EOF, not <<EOF, here, especially you are
writing the here document without indentation with any TAB?