From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 12 Apr 2011 07:15:57 GMT
Subject: Re: [PATCH/RFC 1/7] i18n: mark init-db messages for translation
Message-ID: <7vy63gq6s2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v39lorli9.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>  	fp = fopen(git_link, "w");
>>  	if (!fp)
>> -		die("Could not create git link %s", git_link);
>> -	fprintf(fp, "gitdir: %s\n", git_dir);
>> +		die(_("Could not create git link %s"), git_link);
>> +	fprintf(fp, _("gitdir: %s\n"), git_dir);
>>  	fclose(fp);
>> ...
> I don't think this is correct.  The file "git_link" refers to .git that is
> not a directory but is a regular file whose contents is "gitdir: $path"
> and that should _never_ be localized, so the patch to die() message is Ok,
> but the string given to fprintf(fp, ...) is _not_.

See read_gitfile_gently() in setup.c; that is the reader of the
information contained in this file.