From: Junio C Hamano Date: Wed, 18 May 2011 04:04:06 GMT Subject: Re: [PATCH] compat/regex/regexec.c: Fix some sparse warnings Message-ID: <7vy624ejt5.fsf@alter.siamese.dyndns.org> In-Reply-To: <4DD2B304.90305@ramsay1.demon.co.uk> Ramsay Jones writes: > In particular, sparse issues the following warnings: > > SP compat/regex/regex.c I'd rather leave stuff in compat/ that were imported from other people intact, unless they are functionally wrong. We don't fix their styles either. Replacing our copy with newer versions that have fixed these issues from upstreams is Ok, though.