From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 04 Aug 2011 00:32:22 GMT
Subject: Re: [PATCH v16 5/7] bisect: introduce --no-checkout support into porcelain.
Message-ID: <7vy5za6mp5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1312408626-8600-6-git-send-email-jon.seymour@gmail.com>

Jon Seymour <jon.seymour@gmail.com> writes:

> +bisect_head()
> +{
> +	if test -f "$GIT_DIR/BISECT_HEAD"; then
> +		echo BISECT_HEAD;
> +	else

	if test -f ...
        then
        	echo BISECT_HEAD
	else

> +	    --no-checkout)
> +		mode=--no-checkout;

You seem to be very fond of extraneous semicolons.

Also I very much prefer to write "then" on its own line, indented at the
same level as "if". Consistently doing so will make your if statement a
lot easier to read when some of them need to have multi-line conditionals.