From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 31 May 2012 19:42:11 GMT
Subject: Re: [PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency
Message-ID: <7vy5o85e98.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1338473444-8960-1-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

> In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04),
> http.o started recording GIT_VERSION, but http.o wasn't added
> to the list of files that depends on GIT-VERSION-FILE.
> ...
> diff --git a/Makefile b/Makefile
> index c09a679..59e2b25 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2104,7 +2104,7 @@ configure: configure.ac
>  	$(RM) $<+
>  
>  # These can record GIT_VERSION
> -git.o git.spec \
> +git.o git.spec http.o \
>  	$(patsubst %.sh,%,$(SCRIPT_SH)) \
>  	$(patsubst %.perl,%,$(SCRIPT_PERL)) \
>  	: GIT-VERSION-FILE

Makes sense to me.  Thanks.