From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Sep 2012 00:35:47 GMT
Subject: Re: [PATCH] Improve legibility of test_expect_code output
Message-ID: <7vy5k5cyzg.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAOkDyE-x5NeZX2tpp3C9Kkwb1kPniHptB9ERvtpx2XODufaW=A@mail.gmail.com>

Adam Spiers <git@adamspiers.org> writes:

> On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Adam Spiers <git@adamspiers.org> writes:
>>
>>> ---
>>
>> No explanation why this is a good idea, nor sign-off?
>
> I realised I forgot the sign-off seconds after sending :-(
>
> Isn't it completely self-explanatory? e.g.
>
>     test_expect_code: command exited with 0, we wanted 128 git foo bar
>
> clearly makes more sense than
>
>     test_expect_code: command exited with 0, we wanted 128 from: git foo bar

If it were "..., we wanted 128 from 'git foo bar'", then I would,
but otherwise, not really.