From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 27 Sep 2012 22:31:10 GMT
Subject: Re: [PATCH 4/3] completion: quote completions we find
Message-ID: <7vy5jvnln5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120927214046.GJ10144@goldbirke>

SZEDER Gábor <szeder@ira.uka.de> writes:

> On Wed, Sep 26, 2012 at 05:57:00PM -0400, Jeff King wrote:
>> +		COMPREPLY[$i]="${COMPREPLY[$i]}$stripped"
>
> This reminded me to a mini-series collecting dust in my git repo,
> which converts a few similar var=$var$something constructs to use the
> += append operator instead.

Is the benefit of rewriting it to var+=$something large enough to
worry about the below?

> Now, Bash supports this += append operator since v3.1
> (bash-3.1-alpha1, to be exact), which is around since July 2005, if I
> can trust the mtime at ftp://ftp.cwru.edu/pub/bash/.  MSysgit ships
> v3.1 so it already supports this, too.  So, what is the oldest Bash
> version we care about for completion?