From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 14 Dec 2012 23:17:00 GMT
Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h
Message-ID: <7vy5h0usur.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50CB8C80.6040802@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Am 14.12.2012 20:57, schrieb David Michael:
>> This platform previously included strings.h automatically.  However, the
>> build system now requires an explicit option to do so.
>> 
>> Signed-off-by: David Michael <fedora.dm0@gmail.com>
>> ---
>>  Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/Makefile b/Makefile
>> index fb78f7f..e84b0cb 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1357,6 +1357,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
>>      # Added manually, see above.
>>      NEEDS_SSL_WITH_CURL = YesPlease
>>      HAVE_LIBCHARSET_H = YesPlease
>> +    HAVE_STRINGS_H = YesPlease
>>      NEEDS_LIBICONV = YesPlease
>>      NEEDS_LIBINTL_BEFORE_LIBICONV = YesPlease
>>      NO_SYS_SELECT_H = UnfortunatelyYes
>
> If NONSTOP_KERNEL is the platform that defines __TANDEM, then this
> should be squashed into the previous patch, shouldn't it?

Correct; otherwise 3/4 would break build on that platform.