From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 06 Mar 2013 23:53:17 GMT
Subject: Re: [PATCH v2 1/4] wt-status: split wt_status_state parsing function out
Message-ID: <7vy5e0nl02.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7v4ngoqs8m.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> In other words, with the new world order, wouldn't a saner function
> signature be:
>
> 	static const char *read_and_strip_branch(const char **path);

Eh, discard an asterisk from there.  "Given a string to name the
file, read it to find the branch name recorded in it".

> after this patch?
>
> Also I notice that the error-return cases of this function may be
> wrong even before your patch.  Shouldn't it be doing *branch = NULL
> (and 'return NULL' after the suggested change)?