From: Junio C Hamano Date: Fri, 29 Mar 2013 05:57:29 GMT Subject: Re: [PATCH 2/6] dir.c::match_basename(): pay attention to the length of string parameters Message-ID: <7vy5d6px2u.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130329030217.GA1851@sigill.intra.peff.net> Jeff King writes: > Eek, yeah, that's obviously wrong. Thanks for catching it. Fixing that > clears up all of the test failures outside of t5002. > > And if you move patch 5 ("special case paths that end with a slash") > into position 2, it cleans up the mid-series failures of t5002, making > the series clean for later bisecting. Yeah, the tip becomes test-clean with that "flags" change, but it appears that there seems to be some mismerge (there is another topic or two in flight that want to touch dir.c for pathspecs) that breaks 0003 and 3001 when merged to 'pu'. Duy, can you take another look?