From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 23 May 2013 17:08:16 GMT
Subject: Re: [PATCH 08/17] revision: split some overly-long lines
Message-ID: <7vy5b5fwu7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <519DB6E2.9010900@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> On 05/21/2013 07:34 PM, Junio C Hamano wrote:
>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>> 
>>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>>> ---
>>>  revision.c | 20 ++++++++++++++------
>>>  revision.h | 32 +++++++++++++++++++++-----------
>>>  2 files changed, 35 insertions(+), 17 deletions(-)
>> 
>> Looks obviously good for *.c file, but I am on the fence for *.h
>> one, as the reason we kept these long single lines in *.h files was
>> to help those who want to grep in *.h files to let them view the
>> full function signature.  It probably is OK to tell them to use
>> "git grep -A$n" instead, though.
>
> My goal with this patch was not to set a new policy but rather just to
> make the code conform a little better to the existing policy as
> described in CodingGuidelines.  *If* it is preferred that header files
> list all parameters on a single line, then by all means adjust the
> CodingGuidelines and I will just as happily make header files conform to
> *that* policy when I touch them :-)
>
> (That being said, my personal preference is to apply the 80-character
> limit for header files too.)

Yeah, that is why I said "I am on the fence but it probably is OK to
break" the unwritten but guessable rule.