From: Junio C Hamano Date: Fri, 05 Jul 2013 06:47:04 GMT Subject: Re: [PATCH v9 1/5] t4041, t4205, t6006, t7102: use iso8859-1 rather than iso-8859-1 Message-ID: <7vy59la4gn.fsf@alter.siamese.dyndns.org> In-Reply-To: <38cdab6c314e858ec580b1d0fbf87098c2d92cb0.1372939482.git.Alex.Crezoff@gmail.com> Alexey Shumkin writes: > This is actually a fixup of de6029a2d7734a93a9e27b9c4471862a47dd8123, > which was applied before final patch series was sent. > > Also, see 3994e8a98dc7bbf67e61d23c8125f44383499a1f for the explanation > of such a replacement. These are not very useful in a log message. People who read the history 6 months down the road would want to see why we want to use iso8859-1 not iso-8859-1 explained. Both "iso8859-1" and "iso-8859-1" are understood as latin-1 by modern platforms, but the latter is not understood by older platforms;update tests to use the former. This is in line with 3994e8a9 (t4201: use ISO8859-1 rather than ISO-8859-1, 2009-12-03), which did the same. > Signed-off-by: Alexey Shumkin > Reviewed-by: Johannes Sixt I do not recall this exact patch reviewed by J6t, but perhaps I missed a message on the list?