From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 07 Jul 2013 17:34:18 GMT
Subject: Re: [PATCH 1/4] zero-initialize object_info structs
Message-ID: <7vy59i46lh.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130707100329.GA19143@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Obviously I plan to add a new query type in the next patch, but this
> initialization is probably a reasonable thing to be doing anyway.

Yes. Thanks.

>
>  sha1_file.c | 2 +-
>  streaming.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sha1_file.c b/sha1_file.c
> index 0af19c0..de06a97 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -2428,7 +2428,7 @@ int sha1_object_info(const unsigned char *sha1, unsigned long *sizep)
>  
>  int sha1_object_info(const unsigned char *sha1, unsigned long *sizep)
>  {
> -	struct object_info oi;
> +	struct object_info oi = {0};
>  
>  	oi.sizep = sizep;
>  	return sha1_object_info_extended(sha1, &oi);
> diff --git a/streaming.c b/streaming.c
> index cabcd9d..cac282f 100644
> --- a/streaming.c
> +++ b/streaming.c
> @@ -135,7 +135,7 @@ struct git_istream *open_istream(const unsigned char *sha1,
>  				 struct stream_filter *filter)
>  {
>  	struct git_istream *st;
> -	struct object_info oi;
> +	struct object_info oi = {0};
>  	const unsigned char *real = lookup_replace_object(sha1);
>  	enum input_source src = istream_source(real, type, &oi);