From: Junio C Hamano <junkio@cox.net>
Date: Thu, 07 Sep 2006 04:09:58 GMT
Subject: Re: [PATCH] Fix memory leak in "connect.c".
Message-ID: <7vwt8g48rt.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060907055952.dafffe2b.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> sq_quote allocates some memory that should be freed.

That's technically correct, but the code you are touching is
immediately before exec() or die() so I chose to be sloppy and
short ;-).

With sq_quote_buf() (which was introduced with 77d604 Oct 10
2005), you should be able to directly write into the command[]
buffer, I think.  The code you touched predates that function
(b10d0e July 8 2005).