From: Junio C Hamano <junkio@cox.net>
Date: Tue, 27 Feb 2007 23:45:49 GMT
Subject: Re: [PATCH 2/2] cvsserver: Remove trailing "\n" from commithash in checkin function
Message-ID: <7vwt239nbm.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200702271249.09596.andyparkins@gmail.com>

Andy Parkins <andyparkins@gmail.com> writes:

> The commithash for updating the ref is obtained from a call to
> git-commit-tree.  However, it was returned (and stored) with the
> trailing newline.  This meant that the later call to git-update-ref that
> was trying to update to $commithash was including the newline in the
> parameter - obviously that hash would never exist, and so git-update-ref
> would always fail.
>
> The solution is to chomp() the commithash as soon as it is returned by
> git-commit-tree.
>
> Signed-off-by: Andy Parkins <andyparkins@gmail.com>
>      my $commithash = `git-commit-tree $treehash -p $parenthash < $msg_filename`;
> +	chomp($commithash);
>      $log->info("Commit hash : $commithash");
>  

Thanks.  Do we need to compensate with a trailing LF in the $log
line?