From: Junio C Hamano <junkio@cox.net>
Date: Mon, 09 Apr 2007 00:04:04 GMT
Subject: Re: [PATCH 4/8] git-repack --max-pack-size: add fixup_header_footer()
Message-ID: <7vwt0m76rv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <46197950.3080804@gmail.com>

Dana How <danahow@gmail.com> writes:

> +/*
> + * Move this, the version in fast-import.c,
> + * and index_pack.c:readjust_pack_header_and_sha1 into sha1_file.c ?
> + */
> +static void fixup_header_footer(int pack_fd, unsigned char *pack_file_sha1,
> +				char *pack_name, uint32_t object_count)
> +{

Indeed that is a very good point.

I admit I did not notice we already had the duplication between
fast-import.c and index-pack.c

Shawn, Nico, what do you think?  Wouldn't it be better to
refactor them first, independent of Dana's series?