From: Junio C Hamano Date: Mon, 21 May 2007 23:19:25 GMT Subject: Re: [PATCH] Allow user to specify mailbox format for mailsplit Message-ID: <7vwsz1bw8y.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20070521230524.GC10890@steel.home> Alex Riesen writes: > If the argument ends with a slash - assume it is a Maildir and try to > create it. Otherwise - it is an mbox. Sorry, I am lost here. git-mailsplit is to read an existing mbox and split the pieces of e-mail into the specified output directory. The recent Maildir support is to make it read pieces of e-mails from an existing Maildir (which presumably have bunch of files that store e-mail), isn't it? If the patch were about creating a new _output_ directory (that is, "dir" in cmd_mailsplit), I would understand what you are trying to do, but why would you even want to create the input Maildir in that loop (I take that your patch is on top of Fernando's patch)?