From: Junio C Hamano Date: Wed, 06 Jun 2007 09:21:18 GMT Subject: Re: [PATCH 3/6] git-fsck: Do thorough verification of tag objects. Message-ID: <7vwsyh4ewh.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7vejkp5ua1.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Johan Herland writes: > ... >> Or would you rather switch around the "verbose" and the >> "parse_and_verify_tag_buffer()" (i.e. not even attempt the thorough >> verification unless in verbose mode)? > > Actually I was thinking about doing something like this. > > - if (parse_and_verify_tag_buffer(0, data, size, 1) && verbose) > + if (parse_and_verify_tag_buffer(0, data, size, verbose)) Well, after running fsck with --verbose, I take the whole suggestion back. I think it is a good idea to do the "thorough" tag validation in general, and it should not be buried under the verbose output, which is almost useless unless in a very narrow special case that you are really trying to see which exact object is corrupt. So I think your original patch to signal error on thorough tag validation failure is probably a good approach in general. People need to know that in git.git fsck would return non-zero because of v0.99 tag, but the people who get hit/annoyed by this ought to be minority. It may be the case that a major portion of git users currently are the ones who futz with the git.git repository, but there would be a serious problem if it continues to be the case ;-)