From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 05 Feb 2008 20:02:20 GMT
Subject: Re: [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook
Message-ID: <7vwspj9noz.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <47A88032.107@gnu.org>

Paolo Bonzini <bonzini@gnu.org> writes:

>> I might be missing something
>
> No, you are not.
>
>> but should this not be solved by having the prepare-commit-msg exit
>> 0?  I mean, it is conceivable that such a bad error occurs in the
>> hook that the commit should be stopped then and there.
>
> So you say, don't suppress the hook with --no-verify *and* exit if the
> hook returns 1, even if --no-verify is given.  That's fine by me.

Fine by me as well, and I would prefer it that way.