From: Junio C Hamano Date: Mon, 18 Feb 2008 09:36:35 GMT Subject: Re: [PATCH] Remove useless if-before-free tests. Message-ID: <7vwsp2ppwc.fsf@gitster.siamese.dyndns.org> In-Reply-To: <87pruuy64v.fsf@rho.meyering.net> Jim Meyering writes: > It's a definite loss of portability if you can find a reasonable porting > target for which free(NULL) fails. But even if you do, the fix is > not to reject the clean-up, but to amend it with a wrapper function. > That encapsulates the work-around in one place rather than polluting > all of those files. As we already have unchecked free(ptr) in our code _anyway_, there _technically_ is no reason to reject the clean-up patch. We just need to find a quiescent time to do so so that actively cooking patches in people's trees (and topics in 'next') won't get needless conflicts.