From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Jun 2008 20:42:57 GMT
Subject: Re: [PATCH v2] cat-file --batch / --batch-check: do not exit if hashes are missing
Message-ID: <7vwskyfige.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1212969741-24899-1-git-send-email-LeWiemann@gmail.com>

Lea Wiemann <lewiemann@gmail.com> writes:

> diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
> index 973aef7..542b4ae 100755
> --- a/t/t1006-cat-file.sh
> +++ b/t/t1006-cat-file.sh
> @@ -174,9 +174,27 @@ do
> ...
> +foobar84 missing" = \
> +    "$(( echo foobar42; echo_without_newline foobar84; ) | git cat-file --batch-check)"


I have a slight suspicion that some of the Bourne shell implementations we
support may misinterpret $(( as beginning of arithmetic expansion, so
perhaps we would want an extra SP between the open parens.

Other than that, looked ok.