From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 31 Jul 2008 05:58:13 GMT
Subject: Re: [PATCH v3] Advertise the ability to abort a commit
Message-ID: <7vwsj23896.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080731055024.GA17652@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Jul 30, 2008 at 07:53:11PM +0200, Anders Melchiorsen wrote:
>
>> An empty commit message is now treated as a normal situation, not an error.
>
> As others have commented, I think the right way to say this is probably
> "it is not reported to the user as an error, but still exits with a
> non-zero exit status".
>
> And I think it looks better.
>
> But:
>
>>  			"# Please enter the commit message for your changes.\n"
>> +			"# To abort the commit, use an empty commit message.\n"
>>  			"# (Comment lines starting with '#' will ");
>
> I still prefer a shortened version of these three lines, as I mentioned
> earlier.

I tend to agree; please make it so ;-)