From: Junio C Hamano Date: Sun, 01 Feb 2009 23:43:26 GMT Subject: Re: [PATCH] bash: offer to show (un)staged changes Message-ID: <7vwsc9rae9.fsf@gitster.siamese.dyndns.org> In-Reply-To: <4ac8254d0902011448t242e7fcek3ae7fda609648ef0@mail.gmail.com> Tuncer Ayaz writes: > On Mon, Jan 19, 2009 at 6:29 PM, Shawn O. Pearce wrote: >> Junio C Hamano wrote: >>> Thomas Rast writes: >>> >>> > + if test ! -z "$GIT_PS1_EXPENSIVE"; then >>> > + git update-index --refresh >/dev/null 2>&1 || w="*" >>> >>> This makes the feature unavailable for people who care about the stat >>> dirtiness and explicitly set diff.autorefreshindex to false, doesn't it? >> >> Yup, and I'm one of those people who sets autorefresindex to false >> in my ~/.gitconfig, usually before I even have user.{name,email} set. >> >> I do like the idea of what Thomas is trying to do here, but its >> so bloody expensive to compute dirty state on every prompt in >> some repositories that I'd shoot myself. E.g. WebKit is huge, > > I've been thinking about this and wondered > whether implementing "status --mini" or > "status --short" which prints "+?*" in wt-status.c > could be made fast enough. > > Should we try to implement and profile this > or do we know it will be slow beforehand? I think I've seen a patch to do something like that, soon after Shawn announced his repo tool.