From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Feb 2009 00:31:07 GMT
Subject: Re: [PATCH] Make repack less likely to corrupt repository
Message-ID: <7vwsbxizlg.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200902110127.18149.robin.rosenberg.lists@dewire.com>

Robin Rosenberg <robin.rosenberg.lists@dewire.com> writes:

> onsdag 11 februari 2009 00:56:49 skrev Junio C Hamano:
>> We failed to honor what the end user wanted: to repack.  Why should we
>> exit 0 here?
>
> A repack may or may not yield a better packed repo. In this case, not,
> but for a different reason than failing to find better deltas. Given the
> circumstances that is most likely to cause the "failure (repacking on
> windows), this is "normal" behaviour and no reason to scare the user
> with an error code.

Up to this point, I felt my earlier misconception corrected, but then ...

> The unlink error might be enough.

... I think we should not even show unlink errors, if "this is not an
error, nothing to worry about" is the official stance about such failure;
otherwise the errors will scare people, *and* others then doubly complain
that even the command detects errors, the whole thing does *not* error
out.