From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 11 Feb 2009 16:46:01 GMT
Subject: Re: [PATCH 2/3] completion: Change "if [...]" to "if test ..." to match git convention
Message-ID: <7vwsbwgbw6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1234366634-17900-3-git-send-email-ted@tedpavlic.com>

Ted Pavlic <ted@tedpavlic.com> writes:

> In the single case of:
>
>     if [...] || [...]
>
> changed to:
>
>     if test ... || test ...

In [0/3] you talked about "git convention", but please match the local
convention, especially inside contrib/ area.  That is, consistency of the
style within the same file (and files in vicinity), is more important.

> Also changed:
>
>     if test ...
>     then
>
> to:
>
>     if test ...; then

The prevailing style in bash completion script is to write "then" on the
same line as "if", so I think this is a good example of matching the local
convention (if you are trying to match "git convention", "then" is written
on the same column as "if" on a line by itself for readability, so this
change is going backwards).