From: Junio C Hamano Date: Tue, 19 May 2009 05:20:45 GMT Subject: Re: [PATCH 2/3] commit: add function to unparse a commit and its parents Message-ID: <7vws8d8y8i.fsf@alter.siamese.dyndns.org> In-Reply-To: <200905190616.30132.chriscool@tuxfamily.org> Christian Couder writes: > By the way, when you say that you suspect an attempt to replace an object > that is directly listed on the command line would not work very well with > the current replace series, is it related to the unparsing commit problem? What I fear is something like this. git push $there 04a8c^2:master It would need to parse 04a8c to find its second parent and then start discussing what object to send with the other end. "04a8c^2" is a direct user input and should mean the same commit as git show "04a8c^2" would give the user, so it obviously needs to obey the replace rules (making 04a8c parsed), but the object transfer should not look at replace at all (that's the whole point of not using the "graft hack" that cannot be sanely transferred to the other end).