From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 10 Apr 2010 18:44:28 GMT
Subject: Re: [WIP PATCH 1/4] Prepare checkout_entry() for recursive checkout of submodules
Message-ID: <7vwrwfw3jn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4BC0AED8.1080006@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

>>> This would give you an incorrect result if .git is a file that records
>>> "gitdir: overthere" (see read_gitfile_gently() in setup.c); I would expect
>>> it would become a fairly important ingredient if we ever enhance the
>>> submodule support to add submodule that disappears/reappears in the
>>> history.
>> 
>> Right. This assumption is also present in add_submodule_odb() (used by
>> show_submodule_summary()) and is_submodule_modified(), so i just reused
>> it. This should be addressed in another patch.
>
> What about this one:

Looks sensible to me.  Thanks, and sorry for not catching this earlier.