From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 08 May 2010 03:58:06 GMT
Subject: Re: [PATCH 6/6] Add test_harness make target for testing with prove(1)
Message-ID: <7vwrvfcaep.fsf@alter.siamese.dyndns.org>
In-Reply-To: <m339y3forb.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> The --jobs option I'm supplying to prove(1) is not supported in all
>> prove versions, some older ones (before Perl 5.10.1) don't have
>> it. Anyone that's hacking Git probably has 5.10.1, and you can always
>> use the old `make test` for non-parallel tests.
>
> I am hacking Git, and I don't have perl >= 5.10.1.  On the other hand
> I can alway run "make test" or individual tests instead of 
> "make test_harness".
>
> A better solution would be to check Perl version, or even better of
> "prove" supports '--jobs' option, and selectively enable parallel
> running of test harness in Makefile.

Besides, "make -j15 test" from the toplevel already runs the tests in
parallel.  I don't see much point in this change.